Multiple arguments by option
#295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n for the protobuf-plugin.
armiol
requested changes
Jan 30, 2017
Contributor
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@dmdashenkov please address your TODOs and a single comment.
| GranterEventsEnrichment.class); | ||
| validator.validate(); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Please remove an excessive line.
Codecov Report@@ Coverage Diff @@
## master #295 +/- ##
============================================
+ Coverage 86.49% 86.71% +0.21%
============================================
Files 193 193
Lines 6903 6956 +53
Branches 527 540 +13
============================================
+ Hits 5971 6032 +61
+ Misses 815 801 -14
- Partials 117 123 +6Continue to review full report at Codecov.
|
# Conflicts: # build.gradle # server/src/main/java/org/spine3/server/event/enrich/ReferenceValidator.java # server/src/test/java/org/spine3/server/event/enrich/EventEnricherShould.java
Contributor
Author
|
@armiol PTAL again |
Contributor
Author
|
@armiol Fixed issue with spaces in |
armiol
approved these changes
Jan 31, 2017
Contributor
|
@dmdashenkov LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for multiple-argument
byannotations.The syntax is:
Wildcard syntax (
(by)="*.target_field|no_qualifier_field") is supported in cases when annotationenrichment_forgives a not ambiguous definition for the target type.For FQN field names in the
enrichment_formay be omitted (the same behavior as with a single-argumentbyannotation).