Filter commanding method output for Empty and Nothing instances#895
Merged
dmitrykuzmin merged 6 commits intomasterfrom Nov 30, 2018
Merged
Filter commanding method output for Empty and Nothing instances#895dmitrykuzmin merged 6 commits intomasterfrom
Empty and Nothing instances#895dmitrykuzmin merged 6 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #895 +/- ##
============================================
+ Coverage 93.14% 93.15% +<.01%
Complexity 3802 3802
============================================
Files 522 522
Lines 12540 12541 +1
Branches 710 710
============================================
+ Hits 11681 11682 +1
Misses 629 629
Partials 230 230 |
Contributor
Author
|
@armiol PTAL. |
armiol
approved these changes
Nov 29, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #894.
Previously, the
filterIgnoredmethod was not called for commanding method result to removeEmptyandNothinginstances from the command list.Now, the commanding method result is filtered in the same way as the
CommandHandlerandEventReactorresults.