Add shortcut methods for asserting one event or rejection#897
Merged
alexander-yevsyukov merged 18 commits intomasterfrom Dec 2, 2018
Merged
Add shortcut methods for asserting one event or rejection#897alexander-yevsyukov merged 18 commits intomasterfrom
alexander-yevsyukov merged 18 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #897 +/- ##
===========================================
+ Coverage 93.15% 93.2% +0.05%
- Complexity 3802 3808 +6
===========================================
Files 522 522
Lines 12541 12552 +11
Branches 710 710
===========================================
+ Hits 11682 11699 +17
+ Misses 629 627 -2
+ Partials 230 226 -4 |
Also: fix variable name for a Bounded Context.
Contributor
Author
|
@armiol, there is some strange anomaly of collecting rejections in PTAL to my changes in this PR. I decided to introduce them in relation to my current works on improving Kanban Board example. |
…atus to the `BbProjectAggregate`. Modify a rejection verifies to ensure the rejection is emitted strictly once.
Contributor
|
@alexander-yevsyukov I have addressed your |
armiol
approved these changes
Dec 1, 2018
Contributor
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov LGTM in general. Please see my comment — it's probably more convenient to discuss it in person.
testutil-server/src/main/java/io/spine/testing/server/blackbox/BlackBoxBoundedContext.java
Show resolved
Hide resolved
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
BlackBoxBoundedContext.... it would be possible to write:
It is also possible to write: