Send external events from black box tests#903
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
============================================
+ Coverage 93.19% 93.22% +0.02%
- Complexity 3816 3823 +7
============================================
Files 522 522
Lines 12573 12585 +12
Branches 711 710 -1
============================================
+ Hits 11718 11732 +14
+ Misses 626 625 -1
+ Partials 229 228 -1 |
…events # Conflicts: # testutil-client/src/main/java/io/spine/testing/client/blackbox/ErrorAbsenceVerify.java # testutil-server/src/main/java/io/spine/testing/server/blackbox/BlackBoxBoundedContext.java # testutil-server/src/test/java/io/spine/testing/server/blackbox/BlackBoxBoundedContextTest.java # testutil-server/src/test/java/io/spine/testing/server/blackbox/given/BbProjectAggregate.java # testutil-server/src/test/java/io/spine/testing/server/blackbox/given/Given.java
…black-box-external-events
Contributor
Author
|
@armiol, PTAL. |
…events # Conflicts: # testutil-server/src/main/java/io/spine/testing/server/blackbox/BlackBoxBoundedContext.java # testutil-server/src/test/java/io/spine/testing/server/blackbox/BlackBoxBoundedContextTest.java
armiol
requested changes
Dec 5, 2018
| * @apiNote Returned value can be ignored when this method invoked for test setup | ||
| */ | ||
| @CanIgnoreReturnValue | ||
| public T receivesExternalEvent(Message messageOrEvent) { |
Contributor
There was a problem hiding this comment.
In case of a plain message posted, it's not clear how to set the mandatory ExternalMessage.bounded_context_name field.
| @VisibleForTesting | ||
| final class BlackBoxSetup { | ||
|
|
||
| private final BoundedContextName contextName; |
Contributor
There was a problem hiding this comment.
If the one above resolved, this field requires (maybe) both renaming and explanation OR removal.
| } | ||
|
|
||
| @React(external = true) | ||
| Optional<BbUserUnassigned> on(BbUserDeleted event) { |
Contributor
There was a problem hiding this comment.
BbUserUnassigned is about a user, while we speak of a Project aggregate. So probably this is BbAssigneeRemoved.
| } | ||
|
|
||
| // | ||
| // External User bounded context events |
| // An external event to be imported into an aggretate. | ||
| // An event to be imported into an aggretate. | ||
| // | ||
| message TuCommentRecievedByEmail { |
Contributor
There was a problem hiding this comment.
Let's fix the spelling here as well. TuCommentReceivedByEmail
| repeated BbProjectId project_id = 2; | ||
| } | ||
|
|
||
| message BbAddProjectAssignee { |
Contributor
There was a problem hiding this comment.
Suggested change
| message BbAddProjectAssignee { | |
| message BbAssignProject { |
Contributor
Author
|
@armiol, PTAL. |
armiol
approved these changes
Dec 5, 2018
| * optional external events to be dispatched to the Bounded Context | ||
| * in supplied order | ||
| * @return current instance | ||
| * @apiNote Returned value can be ignored when this method invoked for test setup |
Contributor
There was a problem hiding this comment.
We have agreed to put periods in @apiNote and @implNote, as these are sentences.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
receivesExternalEventcall to theBlackBoxBoundedContext.