Comments configuration#32
Open
Vladyslav-Kuksiuk wants to merge 28 commits into
Open
Conversation
Contributor
This parameter should be treated in context of the embedded file and depend on the type of the programming language of the embedded file. Javadoc, and KDoc are only two formats that use the same convention for the comments ( For other programming languages that we use (Go, Python, JavaScript, TypeScript, etc.) we should treat comments according to the language contentions. For some file formats, the Please have a look around of the file types we use in our projects and use them for sensible defaults. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides comments filtration option.
How to use
Add the
commentsparameter to theembed-codetag.Supported values
all— retain all comments. This is the default.none— strip all recognized comments.documentation— retain documentation comments such as Javadoc, KDoc etc.regular— retain regular comments, including block and inline comments, but strip documentation comments.inline— retain regular inline comments such as//.block— retain regular block comments such as/* */.Not every mode has a distinct meaning for every supported file type.
For example, XML, HTML, and YAML support only
allandnone.Supported formats
Comment filtering is supported for:
Unsupported file types are left unchanged, and a warning is emitted when comment filtering other than
allis requested.Resolves this issue.
Additional changes
checkmode "outdated" output and throw error on it: