Entity column API update #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@armiol, PTAL. |
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
============================================
+ Coverage 94.15% 95.11% +0.96%
- Complexity 469 473 +4
============================================
Files 60 60
Lines 1762 1762
Branches 90 90
============================================
+ Hits 1659 1676 +17
+ Misses 74 57 -17
Partials 29 29 |
armiol
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new column API, there is no difference between the stored column name and the queries column name.
This resolves the issue with querying entities by IDs and columns (which did not work before, if the stored and queried column names did not match).