Expose transaction API #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
============================================
+ Coverage 94.33% 94.48% +0.14%
+ Complexity 530 522 -8
============================================
Files 64 65 +1
Lines 1925 1904 -21
Branches 102 96 -6
============================================
- Hits 1816 1799 -17
Misses 76 76
+ Partials 33 29 -4 |
Contributor
Author
|
@armiol, PTAL. |
Contributor
Author
|
@armiol, PTAL. |
armiol
approved these changes
Jan 29, 2020
Contributor
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@dmdashenkov LGTM with two minor comments to address.
| return TimestampValue.of(fromProto(m.getWhenReceived())); | ||
| receivedAt("received_at", (m) -> { | ||
| Timestamp timestamp = m.getWhenReceived(); | ||
| long epochNanos = timestamp.getSeconds() * NANOS_PER_SECOND + timestamp.getNanos(); |
Contributor
There was a problem hiding this comment.
Please use Timestamps.toNanos(..).
| /** | ||
| * A Cloud Datastore transaction wrapper. | ||
| * | ||
| * @implNote The wrapper provides API for basic operations which can be done transactionally. |
Contributor
There was a problem hiding this comment.
Please rephrase (as discussed) to emphasize on the Datastore limits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the API of the Cloud Datastore-based storage. In particular, we make it easier to work with transactions. The new methods of
TransactionWrappercover all the necessary database operations.Also, in this PR, we update the format of
InboxMessagestorage. Previously,InboxMessages had a Timestamp propertywhen_received. However, with the latest time-related changes in the framework, the precision of the Datastore Timestamp is now not enough for us. Thus, we introduce a new columnreceived_at, which contains the number of nanoseconds, elapsed since the Unix epoch start. Though nanoseconds are, strictly speaking, a lie, this is good enough for our technical purposes.As another side effect of the time-related changes, the standard idiom for querying entities by a time-based property has changed. Instead of passing an
equalsfilter, it is recommended toequalsfilter with a value rounded down to a whole microsecond;