-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate remaining code to Kotlin #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
============================================
- Coverage 14.82% 14.37% -0.46%
+ Complexity 147 120 -27
============================================
Files 102 102
Lines 2691 2658 -33
Branches 374 377 +3
============================================
- Hits 399 382 -17
+ Misses 2262 2245 -17
- Partials 30 31 +1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR completes the migration of remaining Java production code to Kotlin, focusing primarily on logging backend and platform implementations. The changes also include a version bump from 2.0.0-SNAPSHOT.400 to 2.0.0-SNAPSHOT.410.
- Migrated Java logging backend implementations to Kotlin
- Migrated platform system components from Java to Kotlin
- Updated version numbers across build files and dependencies
Reviewed Changes
Copilot reviewed 34 out of 35 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Version bump to 2.0.0-SNAPSHOT.410 |
| pom.xml | Version bump to 2.0.0-SNAPSHOT.410 |
| platforms/jvm-default-platform/src/test/kotlin/io/spine/logging/backend/system/DefaultPlatformSpec.kt | Updated method names from getXxxImpl to doGetXxxImpl for test methods |
| platforms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/SystemClock.kt | Migrated from Java to Kotlin |
| platforms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/StackBasedCallerFinder.kt | Migrated from Java to Kotlin |
| platforms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/DefaultPlatform.kt | Migrated from Java to Kotlin |
| contexts/grpc-context/src/main/kotlin/... | Migrated grPC context classes from Java to Kotlin |
| backends/log4j2-backend/src/main/kotlin/... | Migrated Log4j2 backend classes from Java to Kotlin |
| backends/jul-backend/src/main/kotlin/... | Migrated JUL backend classes from Java to Kotlin |
| dependencies.md | Updated timestamps and version references |
Files not reviewed (1)
- .idea/inspectionProfiles/Project_Default.xml: Language not supported
platforms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/SystemClock.kt
Show resolved
Hide resolved
...m-default-platform/src/main/kotlin/io/spine/logging/backend/system/StackBasedCallerFinder.kt
Show resolved
Hide resolved
...orms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/DefaultPlatform.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # dependencies.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 34 out of 35 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- .idea/inspectionProfiles/Project_Default.xml: Language not supported
platforms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/SystemClock.kt
Outdated
Show resolved
Hide resolved
backends/log4j2-backend/src/test/kotlin/io/spine/logging/backend/log4j2/ValueQueueSpec.kt
Show resolved
Hide resolved
contexts/grpc-context/src/main/kotlin/io/spine/logging/context/grpc/GrpcContextDataProvider.kt
Show resolved
Hide resolved
...orms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/DefaultPlatform.kt
Show resolved
Hide resolved
armiol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-yevsyukov LGTM except for a tiny request.
This PR migrates remaining production code from Java to Kotlin.
Other notable changes
flogger.now use the prefixspine.logging..