Fix merging desc.ref files#238
Merged
alexander-yevsyukov merged 3 commits intomasterfrom Oct 22, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Shadow plugin configuration to use the correct method for merging Descriptor Set reference files, incrementing the version from 2.0.0-SNAPSHOT.353 to 2.0.0-SNAPSHOT.354.
- Changed
mergeServiceFiles("desc.ref")toappend("desc.ref")to comply with new Shadow plugin requirements - Updated project version across all modules and documentation
- Regenerated dependency report with new timestamps
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| buildSrc/src/main/kotlin/fat-jar.gradle.kts | Fixed descriptor set reference file merging by switching from mergeServiceFiles to append |
| version.gradle.kts | Incremented snapshot version to 354 |
| pom.xml | Updated artifact version to match new snapshot |
| dependencies.md | Regenerated dependency report with updated version numbers and timestamps |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
=========================================
Coverage 34.47% 34.47%
Complexity 282 282
=========================================
Files 136 136
Lines 3231 3231
Branches 247 247
=========================================
Hits 1114 1114
Misses 2040 2040
Partials 77 77 🚀 New features to boost your workflow:
|
armiol
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes merging Descriptor Set reference files by calling
appendinstead ofmergeServiceFileas new Shadow plugin requires.