Fix publishing of the ksp module
#251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armiol
approved these changes
Dec 17, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the publishing configuration for the ksp module by adding it to the list of production modules in spinePublishing. The omission caused incorrect dependency references in the published java module's pom.xml, which lacked the validation- prefix for the ksp module.
- Added
kspto the production modules list inspinePublishingconfiguration - Updated project version from
2.0.0-SNAPSHOT.377to2.0.0-SNAPSHOT.378 - Corrected a comment in
java-bundlereferring to "Compiler backend" instead of "ProtoData backend"
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| build.gradle.kts | Added ksp module to the spinePublishing.modules set to ensure proper publication with correct artifact naming |
| java-bundle/build.gradle.kts | Updated comment to correctly reference "the Compiler backend" instead of "ProtoData backend" |
| version.gradle.kts | Bumped validation version to 2.0.0-SNAPSHOT.378 |
| pom.xml | Updated version to match the new validation version |
| dependencies.md | Auto-generated dependency report with updated version numbers and generation timestamps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the list of production modules in
spinePublishingto include thekspmodule which was missing until this PR. The omission, in turn, lead to incorrect dependency inpom.xmlof the publishedjavamodule, which depends onksp. The incorrect dependency missed thevalidation-prefix ofkspmodule publication.