Skip to content

Fix JVM runtime artifact coordinates#287

Merged
alexander-yevsyukov merged 9 commits intomasterfrom
fix-jvm-runtime-coordinates
Apr 3, 2026
Merged

Fix JVM runtime artifact coordinates#287
alexander-yevsyukov merged 9 commits intomasterfrom
fix-jvm-runtime-coordinates

Conversation

@alexander-yevsyukov
Copy link
Copy Markdown
Collaborator

This PR removes the customisation of the jvm-runtime Maven artefact ID, which is no longer needed. The customisation block added additional spine- prefix for the publication of the previous PR.

Copilot AI review requested due to automatic review settings April 3, 2026 18:42
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review April 3, 2026 18:42
@alexander-yevsyukov alexander-yevsyukov self-assigned this Apr 3, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project snapshot version and removes a now-redundant customization that previously altered the published Maven artifactId for the jvm-runtime module.

Changes:

  • Bump Validation SDK version from 2.0.0-SNAPSHOT.410 to 2.0.0-SNAPSHOT.411 across build metadata and docs.
  • Remove the afterEvaluate { publishing { ... } } block in jvm-runtime that customized the published artifactId.
  • Refresh generated dependency/license and POM reports to the new snapshot version.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
version.gradle.kts Updates the shared validationVersion used across the Gradle build.
pom.xml Updates the generated dependency summary POM to the new snapshot version.
jvm-runtime/build.gradle.kts Removes custom publication logic for artifactId to rely on standard publishing configuration.
docs/content/docs/validation/01-getting-started/adding-to-build.md Updates the documented plugin version to the new snapshot.
dependencies.md Updates the generated dependency/license report for the new snapshot (but see comment).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings April 3, 2026 19:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

jvm-runtime/build.gradle.kts:76

  • After removing the afterEvaluate { publishing { ... } } customization, the imports io.spine.gradle.publish.SpinePublishing and io.spine.gradle.publish.StandardJavaPublicationHandler are now unused in this script. Please remove them to avoid Kotlin DSL compilation warnings/errors (e.g., if the build treats warnings as errors).
}

forceSpineBase()


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexander-yevsyukov alexander-yevsyukov merged commit de6df7a into master Apr 3, 2026
8 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the fix-jvm-runtime-coordinates branch April 3, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants