Fix merging desc.ref files#290
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix merging of desc.ref files during fat JAR construction for the java-bundle module by applying a shared ShadowJar configuration helper.
Changes:
- Replace ad-hoc
ShadowJarconfiguration (append("desc.ref")+ targeted service merge) withio.spine.gradle.publish.setup()for consistent merging behavior. - Regenerate
dependencies.mdlicense report timestamps.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| buildSrc/src/main/kotlin/fat-jar.gradle.kts | Switches shadowJar configuration to the shared setup() helper to ensure desc.ref merging works correctly. |
| dependencies.md | Updates generated license report timestamps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
This PR updates the Validation SDK snapshot version and adjusts the java-bundle fat-JAR build so descriptor references (desc.ref) and service files are merged via the shared ShadowJar.setup() configuration.
Changes:
- Bump published snapshot version from
2.0.0-SNAPSHOT.412to2.0.0-SNAPSHOT.413across Gradle, Maven, and docs. - Update fat-JAR (
shadowJar) configuration to useio.spine.gradle.publish.setup()(intended to fixdesc.refmerging). - Refresh
dependencies.mdfor the new snapshot.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Bumps the SDK publish version to .413. |
| pom.xml | Aligns Maven project version to .413. |
| docs/content/docs/validation/01-getting-started/adding-to-build.md | Updates the plugin version in docs to .413. |
| dependencies.md | Updates the generated dependency/license report for .413. |
| buildSrc/src/main/kotlin/fat-jar.gradle.kts | Switches shadowJar configuration to shared setup() to handle merging (incl. desc.ref). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| The dependencies distributed under several licenses, are used according their commercial-use-friendly license. | ||
|
|
||
| This report was generated on **Thu Apr 23 20:08:09 WEST 2026** using | ||
| This report was generated on **Fri Apr 24 19:11:43 WEST 2026** using |
This PR fixes merging of
desc.reffiles when building a fat JAR for thejava-bundlemodule.