refactor(host-internal): LSP 宿主实现迁入 host-internal 并收口 agent-core 契约#70
Merged
Conversation
将 TLS 连接、PATH 探测、文档同步与写后 append 从 agent-core 迁至 host-internal/lsp；agent-core 仅保留工具契约与格式化；CLI bridge 经 host-internal 动态绑定 LSP 能力。
将 service-lsp 工作区缓存/dispose 逻辑迁至 host-internal/lsp/workspace-cache， Desktop service 改从 @spirit-agent/host-internal/lsp 引用。
agent-core/lsp 现仅含 types、constants、tool-definitions、tool-request 与 format-diagnostics；jsonrpc 依赖已移至 host-internal，NOTICE 同步重生成。
CLI bridge 通过 CliHostInternalModule 注入 LspService 与 write-append； agent-core smoke:lsp 脚本转发至 host-internal。
全量 build、host-internal LSP 单测、agent-core 契约测试、desktop test:host 与 smoke:lsp 均已通过；NOTICE 中 jsonrpc 归属 host-internal。
Collaborator
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit acbd00c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-core迁至@spirit-agent/host-internal/lsp，agent-core/lsp仅保留工具契约与诊断格式化。LspService等实现；CLI host-bridge 经CliHostInternalModule动态注入 LSP，避免 agent-core 静态依赖 host-internal。vscode-jsonrpc/vscode-languageserver-protocol依赖与 NOTICE 归属 host-internal；新增windows-path.ts避免依赖 agent-core 内部路径。Test plan
npm run build（agent-core + host-internal + desktop）npm --prefix packages/host-internal run test:lsp（10/10）npm --prefix apps/desktop run test:host（116/116，含 lsp-snapshot 与 lspWriteDiagnostics）npm --prefix packages/host-internal run smoke:lsp