Skip to content

added template for creating PRs#2

Merged
CarlinWilliamson merged 7 commits intomasterfrom
pr-template
Oct 10, 2020
Merged

added template for creating PRs#2
CarlinWilliamson merged 7 commits intomasterfrom
pr-template

Conversation

@CarlinWilliamson
Copy link
Copy Markdown
Contributor

@CarlinWilliamson CarlinWilliamson commented Oct 8, 2020

Description 💬

Added a template for PRs so we can have some consistency.
Will also encourage people to include a link to the preview (thanks Andrew!) in their PR so things are easier to review

How Has This Been Tested? 🖥️

Preview

Checklist ✅:

  • Added a description of my changes
  • I assigned the story to myself on pivotal tracker before I started working on this
  • Added details of how I tested my changes
  • Replaced with the branch we're merging from

@CarlinWilliamson
Copy link
Copy Markdown
Contributor Author

Please suggest more additions for the checklist (You can do them inline on github)
We'll squash this when we merge so don't worry about stupid single line commits...

Co-authored-by: CarlinWilliamson <31083798+CarlinWilliamson@users.noreply.github.com>
CarlinWilliamson and others added 3 commits October 10, 2020 11:53
Co-authored-by: Andrew Wong <andrew.j.wong@outlook.com>
Co-authored-by: Andrew Wong <andrew.j.wong@outlook.com>
@CarlinWilliamson CarlinWilliamson merged commit d658183 into master Oct 10, 2020
@featherbear featherbear deleted the pr-template branch October 15, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants