Skip to content

Multiple changes to add tray for MacOS. Changes in visual items#76

Closed
okgarces wants to merge 6 commits intoSplode:devfrom
okgarces:master
Closed

Multiple changes to add tray for MacOS. Changes in visual items#76
okgarces wants to merge 6 commits intoSplode:devfrom
okgarces:master

Conversation

@okgarces
Copy link
Copy Markdown
Contributor

@okgarces okgarces commented Apr 5, 2020

Restore __static variable

If tray exists but window is closed

Minor changes. Reset timer if window is closed

Restore __static variable

If tray exists but window is closed

Minor changes. Reset timer if window is closed
@okgarces
Copy link
Copy Markdown
Contributor Author

okgarces commented Apr 5, 2020

This could be an approach for add system tray icon and logic. I change some UI please let me know what do you think about it.

Right now, it's working in my MacOS, I am going to make tests in Windows as well.

@Splode
Copy link
Copy Markdown
Owner

Splode commented Apr 6, 2020

Hi @okgarces and thanks for your contribution.

I've tested this on macOS and it works nicely. However, there are some issues with Windows, as the default taskbar position is at the bottom of the screen. When the window is restored from the tray, it is positioned below the taskbar, which makes sense for macOS, but positions the window offscreen.

Also, I'm not sure about the stylistic changes to the UI. I see that you've made the layout more efficient in terms of space, but I think some of the proportions between elements are lost.

I think there's a way to incorporate some of the fine work that you've done, but it will require a bit more looking into, especially with regards to Windows.

Thanks again!

@okgarces
Copy link
Copy Markdown
Contributor Author

okgarces commented Apr 7, 2020

Hi @Splode. I will tackle the Windows issues and I will update the PR.
About the UI changes, I think is more efficient and the screen is not too wide. However, I can go back with styles or how can I improve those?

@Splode
Copy link
Copy Markdown
Owner

Splode commented Apr 9, 2020

@okgarces let's go back to the original UI style for this particular PR. I'm still open to the UI changes, but can you please make a separate PR for the style updates?

@okgarces
Copy link
Copy Markdown
Contributor Author

@Splode thanks! I am working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants