Multiple changes to add tray for MacOS. Changes in visual items#76
Multiple changes to add tray for MacOS. Changes in visual items#76okgarces wants to merge 6 commits intoSplode:devfrom
Conversation
Restore __static variable If tray exists but window is closed Minor changes. Reset timer if window is closed
|
This could be an approach for add system tray icon and logic. I change some UI please let me know what do you think about it. Right now, it's working in my MacOS, I am going to make tests in Windows as well. |
|
Hi @okgarces and thanks for your contribution. I've tested this on macOS and it works nicely. However, there are some issues with Windows, as the default taskbar position is at the bottom of the screen. When the window is restored from the tray, it is positioned below the taskbar, which makes sense for macOS, but positions the window offscreen. Also, I'm not sure about the stylistic changes to the UI. I see that you've made the layout more efficient in terms of space, but I think some of the proportions between elements are lost. I think there's a way to incorporate some of the fine work that you've done, but it will require a bit more looking into, especially with regards to Windows. Thanks again! |
|
Hi @Splode. I will tackle the Windows issues and I will update the PR. |
|
@okgarces let's go back to the original UI style for this particular PR. I'm still open to the UI changes, but can you please make a separate PR for the style updates? |
|
@Splode thanks! I am working on it. |
Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com>
…ocket-extensions-0.1.4 chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4
Restore __static variable
If tray exists but window is closed
Minor changes. Reset timer if window is closed