fix(schema): cast to VARCHAR before approx_distinct, add --verbose to…#7
Merged
Conversation
… schema
DataFusion 43 reads parquet with schema_force_view_types=true, coercing
LargeUtf8 to Utf8View. The HLL implementation behind approx_distinct does
not support Utf8View or Date32 at execution time — the planner accepts
them but .collect() panics. Casting to VARCHAR before the aggregate
handles every physical type: string-like columns are free casts, dates
and timestamps produce their canonical string form so distinct counts
remain correct.
Also adds --verbose to the schema subcommand so the full anyhow error
chain is visible on failure, consistent with the validate subcommand.
Without this flag the root cause was completely hidden behind the
top-level context string ("Failed to collect results").
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… schema
DataFusion 43 reads parquet with schema_force_view_types=true, coercing LargeUtf8 to Utf8View. The HLL implementation behind approx_distinct does not support Utf8View or Date32 at execution time — the planner accepts them but .collect() panics. Casting to VARCHAR before the aggregate handles every physical type: string-like columns are free casts, dates and timestamps produce their canonical string form so distinct counts remain correct.
Also adds --verbose to the schema subcommand so the full anyhow error chain is visible on failure, consistent with the validate subcommand. Without this flag the root cause was completely hidden behind the top-level context string ("Failed to collect results").