[WIP] Implement BanData#138
Closed
jamierocks wants to merge 7 commits intoSpongePowered:feature/bansfrom
jamierocks:feature/bans
Closed
[WIP] Implement BanData#138jamierocks wants to merge 7 commits intoSpongePowered:feature/bansfrom jamierocks:feature/bans
jamierocks wants to merge 7 commits intoSpongePowered:feature/bansfrom
jamierocks:feature/bans
Conversation
Member
There was a problem hiding this comment.
This isn't just a Set, it's a Set<Ban>.
Contributor
Author
There was a problem hiding this comment.
I'm pretty sure thats what I did :S
Fixing now.
Aaron1011
force-pushed
the
feature/bans
branch
from
cef5db6 to
f3a2ff2
Compare
Contributor
Author
|
This should be ready to merge, would you like me to squash the commits? |
Member
|
Please update according to the changes recently merged. |
Member
|
@jamierocks Am I correct in thinking that you spoke with @Aaron1011 about re-representing bans and whitelist as a service perspective instead of a Data perspective in the API? |
Contributor
Author
|
Yes you are. As to why I haven't updated this PR. |
Member
|
@jamierocks So I would think that this PR should be closed if such an API change is going to be made (since I did speak to him about approving the change). |
Contributor
Author
|
Yeah, it should. (I was waiting for confirmation from you). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As this is my first time implementing something from the Data API, I am making the process open so I don't make a mess of things.
Upon completion I will squash all the commits, unless you'd rather do that.
tldr; please correct me. pr is not yet finished.