Add item groups (aka creative tabs)#2000
Closed
Conversation
ghost
requested a review
from 
ghost
mentioned this pull request
kashike
suggested changes
Jul 17, 2018
| @@ -0,0 +1,23 @@ | |||
| package org.spongepowered.test; | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ghost
changed the title
ImMorpheus
reviewed
Jul 17, 2018
|
|
||
| @Override | ||
| public Translation getTranslation() { | ||
| return new SpongeTranslation("itemGroup." + this.tabLabel); |
Contributor
There was a problem hiding this comment.
Translations should be lazy loaded
|
|
||
| @Override | ||
| public String getName() { | ||
| return getId(); |
Contributor
There was a problem hiding this comment.
Once #1792 is merged, you'll see the warning during the tests.
Author
|
~wip |
ghost
changed the title
Move implementation to SpongeVanilla
Move implementation from SpongeVanilla back to SpongeCommon
* Lazy load translation * In getName(), return getTranslation().get() instead of getId()
ghost
mentioned this pull request
Author
|
~qa |
limbo-app
added
status: needs review
Member
|
Since bleeding (API 8) will be targeting Minecraft 1.13, I'm going to keep the implementation not merged until we have a 1.13 workspace ready. I'm not wanting to squash the API, I just want the API to be implementable when we are getting 1.13 to work, instead of having to rip the API apart again. I haven't personally checked if there's much changes regardless. |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon | SpongeForge
ItemGroupRegistryModuleandItemGroupTest