feat: unify Player Item Toss Events #4164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we can assert the event is the same one being generated, we can implicitly cast via the compiler. Just like DataProcessors do, we have some liberty to do this with events.
Using an event bridge, we can better manage when we throw the events on Sponge as a bridge. This has been verified through internal testing when using both a Sponge plugin and a mod event listener.
Enchantments can only reference a ServerLevel, so we keep the injection points in Player, but will override their injection points on ServerPlayer. This will still enable the event being thrown on the client, but only add the DamageModifiers on the server (where they belong).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces yet another
@Overwriteand re-enables cross platform events for Items being tossed. We still will have our game transactions performing in the background, but for the immediate events, we'll be able to have mod compatibility on this front.