New event. CommandProcessEvent#888
Closed
djxy wants to merge 5 commits intoSpongePowered:bleedingfrom
djxy:feature/CommandProcessEvent
Closed
New event. CommandProcessEvent#888djxy wants to merge 5 commits intoSpongePowered:bleedingfrom djxy:feature/CommandProcessEvent
djxy wants to merge 5 commits intoSpongePowered:bleedingfrom
djxy:feature/CommandProcessEvent
Conversation
| import org.spongepowered.api.command.CommandResult; | ||
| import org.spongepowered.api.command.CommandSource; | ||
| import org.spongepowered.api.command.InvocationCommandException; | ||
| import org.spongepowered.api.command.*; |
Author
There was a problem hiding this comment.
My bad, Intellij Idea did it automatically. I will change that.
Member
|
I don't see any reason to have SendCommandEvent and CommandProcessEvent.Pre be separate -- their functionality is close enough that you should be able to combine them |
Author
|
Yes, I talked with @ryantheleach and we thought their functionalities were close. I will combine them. |
Author
|
I removed SendCommandEvent and I replaced it by CommandProcessEvent.Pre |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed an event to handle the process of a command before and after that happen in the same tick. So I created this new event to handle that.
When some commands are fired by some players, I need to disable some functionalities. /help is one of them.
Currently there is only one event for when a command is send and it is SendCommandEvent. The commandResult isn't good.
https://github.com/SpongePowered/SpongeCommon/blob/bleeding/src/main/java/org/spongepowered/common/command/SpongeCommandManager.java#L258
SpongeAPI: SpongePowered/SpongeAPI#1333