Skip to content

Fix CatalogTypes#1777

Closed
ImMorpheus wants to merge 4 commits into
SpongePowered:1.13from
ImMorpheus:fix/catalogtypes
Closed

Fix CatalogTypes#1777
ImMorpheus wants to merge 4 commits into
SpongePowered:1.13from
ImMorpheus:fix/catalogtypes

Conversation

@ImMorpheus
Copy link
Copy Markdown
Contributor

@ImMorpheus ImMorpheus commented Feb 10, 2018 •
edited by ryantheleach
Loading

SpongeAPI | SpongeCommon

@ImMorpheus ImMorpheus mentioned this pull request Feb 10, 2018
Closed
@ImMorpheus ImMorpheus changed the title Fix catalogtypes Fix CatalogTypes Feb 10, 2018
@ImMorpheus ImMorpheus force-pushed the fix/catalogtypes branch 2 times, most recently from 3494786 to dd498d3 Compare July 18, 2018 21:48
ST-DDT
ST-DDT reviewed Aug 22, 2018
View reviewed changes
Comment thread src/main/java/org/spongepowered/api/item/ItemType.java
return ItemStack.of(this, 1).createSnapshot();
}

Translation getTranslation(ItemStack stack);
Copy link
Copy Markdown
Member

@ST-DDT ST-DDT Aug 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there already ItemStack#getTranslation?

Copy link
Copy Markdown
Contributor Author

@ImMorpheus ImMorpheus Aug 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is used by ItemStack#getTranslation to take advantage of polymorphism since you need the ItemType to translate the ItemStack.

See Item#getTranslationKey(ItemStack stack) in minecraft code for a similar approach.

@gabizou gabizou added branch: bleeding api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023) and removed api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023) labels Aug 30, 2018
@ImMorpheus ImMorpheus changed the base branch from bleeding to 1.13 February 2, 2019 16:00
@ImMorpheus ImMorpheus added api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023) and removed branch: bleeding labels Feb 2, 2019
@ImMorpheus ImMorpheus requested a review from Cybermaxke February 2, 2019 20:30
@gabizou gabizou closed this Oct 8, 2019
@JBYoshi
Copy link
Copy Markdown
Member

JBYoshi commented Oct 9, 2019

Note: This PR was automatically closed because the 1.13 branch was deleted. It will need to be reopened to target api-8 instead. See #1428 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Deamon5550 Deamon5550 Awaiting requested review from Deamon5550

@gabizou gabizou Awaiting requested review from gabizou

@Faithcaio Faithcaio Awaiting requested review from Faithcaio

@kashike kashike Awaiting requested review from kashike

@Cybermaxke Cybermaxke Awaiting requested review from Cybermaxke

1 more reviewer

@ST-DDT ST-DDT ST-DDT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023) status: needs review status: needs testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ImMorpheus @JBYoshi @ST-DDT @gabizou @limbo-app