Refactoring and implementation of the LaunchProjectileEvent#1769
Closed
RedNesto wants to merge 9 commits into
Closed
Refactoring and implementation of the LaunchProjectileEvent#1769RedNesto wants to merge 9 commits into
RedNesto wants to merge 9 commits into
Conversation
Contributor
Author
|
~wip |
Member
|
This will need to be re-done and re-target |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon
This PR implement its SpongeAPI counterpart.
When is the event fired ?
Here are each cases I tested:
Tell me if you see a case of projectile I missed.
And there is the content of a test plugin
Note: It seems that there are two projectile-relatedEventContextKeys,PROJECTILE_SOURCEandTHROWER, from what I saw, only one would be necessary, I may address this issue later if it is considered as one.Fixed in 5d0184d