Skip to content

Consistent catalog builders.#2174

Merged
Cybermaxke merged 1 commit into
bleedingfrom
consistent-catalog-builders
Jan 26, 2019
Merged

Consistent catalog builders.#2174
Cybermaxke merged 1 commit into
bleedingfrom
consistent-catalog-builders

Conversation

@Cybermaxke
Copy link
Copy Markdown
Contributor

@Cybermaxke Cybermaxke commented Jan 20, 2019

API | Common | Forge

Updates PR #2075 for bleeding.

Comment thread testplugins/src/main/java/org/spongepowered/test/inventory/RecipeTest.java Outdated
@ImMorpheus
Copy link
Copy Markdown
Contributor

Search for CatalogKey id, may as well fix naming inconsistencies

See #1792

@Cybermaxke
Copy link
Copy Markdown
Contributor Author

@ImMorpheus I am not going to fix every name in this PR. Maybe for a separate one, or are you planning to update that PR?

…the register event.

- Furnace recipe is now a catalog type.
@Cybermaxke Cybermaxke force-pushed the consistent-catalog-builders branch from 61f5570 to e99ef96 Compare January 26, 2019 14:27
@ImMorpheus
Copy link
Copy Markdown
Contributor

Oh okay, I was assuming things since you did it for SpongeDataRegistration

I will update that PR.

@Cybermaxke Cybermaxke merged commit e99ef96 into bleeding Jan 26, 2019
@Cybermaxke Cybermaxke deleted the consistent-catalog-builders branch January 27, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch: bleeding status: needs testing does this run, does it solve the issue etc version: 1.16 (u) API: 8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants