Consistent catalog builders + move recipe registration#1952
Merged
Conversation
Cybermaxke
added
branch: bleeding
status: needs testing
api: 8 (u)
Cybermaxke
commented
Jan 20, 2019
Cybermaxke
commented
Jan 20, 2019
Cybermaxke
changed the title
Cybermaxke
force-pushed
the
consistent-catalog-builders
branch
from
ed6d40c to
6eda763
Compare
gabizou
approved these changes
Jan 23, 2019
Member
gabizou
left a comment
gabizou
left a comment
There was a problem hiding this comment.
Seeing as we're royally breaking API and avoiding our deprecation policy for API 8, this change is fine. I wouldn't be opposed to having the legacy interface heavily deprecated and legacy methods in some places deprecated for easier transition, but the changes themselves are good.
| * determine which plugin was used to construct the {@link CatalogType}.</p> | ||
| * | ||
| * @return The built catalog type | ||
| * @throws IllegalStateException If not all required options were specified |
Member
There was a problem hiding this comment.
Throws another exception if this is being called asynchronously as the CauseStackManager cannot be accessed off main thread(s) (when client is introduced, client thread will have a cause stack manager as well as the server thread).
May want to just add documentation for the overriding methods in various builders that outline the "requirements" for this build to succeed and not fail.
gabizou
approved these changes
Jan 26, 2019
Cybermaxke
force-pushed
the
consistent-catalog-builders
branch
from
a2781c1 to
bacb7d1
Compare
…the register event. - Furnace recipe is now a catalog type. - Remove crafting recipe catalog. - Improve game registry event and additional catalog registry javadoc.
Cybermaxke
force-pushed
the
consistent-catalog-builders
branch
from
bacb7d1 to
c44c395
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API | Common | Forge
Updates PR #1870 for bleeding.