Skip to content

Remove API that appears to be unnecessary with immutable types #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zml2008 merged 2 commits into from
May 3, 2021
Merged

Remove API that appears to be unnecessary with immutable types #31

zml2008 merged 2 commits into from
May 3, 2021

Conversation

@zml2008
Copy link
Member

@zml2008 zml2008 commented Apr 30, 2021

  • Immutable types are no longer Cloneable, since there's no real reason to copy them. For the same reason, copy constructors for equal types have been removed.
  • Default constructors have been removed -- they are redundant with the class constants that already exist.

I'll leave this up for a little while in case there are any objections to removing this API.

@zml2008 zml2008 self-assigned this Apr 30, 2021
@zml2008 zml2008 added this to the 2.0.0 milestone Apr 30, 2021
@zml2008 zml2008 merged commit e11143b into master May 3, 2021
@zml2008 zml2008 deleted the cleanup/drop-unnecessary-api branch May 3, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@zml2008 zml2008

Labels

enhancement

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zml2008