Revert to prior init mechanism to support pypy#202
Merged
SpotlightKid merged 1 commit intoSpotlightKid:masterfrom May 26, 2024
Merged
Revert to prior init mechanism to support pypy#202SpotlightKid merged 1 commit intoSpotlightKid:masterfrom
SpotlightKid merged 1 commit intoSpotlightKid:masterfrom
Conversation
Owner
|
Thanks for the PR. I added PyPy builds to the CI in #203 and everything seems to build fine after the change, so I'm going to merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the change to meson, the ability to compile under pypy was lost.
Reverting just that change - ie restoring py_init.h and differentiating there on what to call restores compatibility with pypy