Fix/reset timeout on redirect #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring3
force-pushed
the
fix/reset-timeout-on-redirect
branch
from
4425dd0 to
e769820
Compare
Spring3
added a commit
that referenced
this pull request
May 29, 2021
* chore: bump dependencies * fix: reset timeout and interval when redirected within twitch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it looks like twitch is displaying the channel point button based on it's internally stored timestamps.
This means that if a button is rendered and hasn't been clicked on time, the next time it appears in 15 minutes from the moment it was rendered, not from the moment it was clicked.
And I noticed sometimes that if I switched to a channel, where apparently during the previous session the button was clicked with a delay, it was hanging and the content script wasn't awake on time to click it again. And it ended in an endless loop of button being rendered, hanging there for some time, before clicked with yet another delay.
I think that the problem lies in redirects and the intervals being left in the same state as before the redirect.
This PR should fix it.
I am currently testing it locally to see if I notice the same behaviour appear again. Hopefully not and this can go in v1.2.4