Updated follow-redirect package reference from http-proxy#108
Merged
TensAndTwenties merged 3 commits intodevelopfrom Jan 21, 2022
Merged
Updated follow-redirect package reference from http-proxy#108TensAndTwenties merged 3 commits intodevelopfrom
TensAndTwenties merged 3 commits intodevelopfrom
Conversation
TensAndTwenties
requested review from
902seanryan,
aberkie and
corinnejean
as code owners
902seanryan
requested changes
Jan 19, 2022
Contributor
902seanryan
left a comment
902seanryan
left a comment
There was a problem hiding this comment.
Changes look good! Just got to fix the changelog issue.
I'd probably include the changes under a new 2.2.5 release version with "unreleased" as the date though
corinnejean
requested changes
Jan 19, 2022
Contributor
corinnejean
left a comment
corinnejean
left a comment
There was a problem hiding this comment.
just re-request my review once you address Sean's comment
902seanryan
approved these changes
Jan 20, 2022
corinnejean
approved these changes
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket