Fix sub channel volume bug #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymccurdy-redspace
approved these changes
Oct 5, 2023
Contributor
Author
|
From my local setup, able to mute music and have sound stay on. Would still like to get some confirmation from the games app work before merging and tagging |
Contributor
Author
|
Forgot to account for mute buttons. Going to work on updating that now |
corinnejean
approved these changes
Oct 6, 2023
Contributor
Author
|
Updated the logic fairly substantially. Will be recording a demo for review later. |
corinnejean
approved these changes
Oct 12, 2023
selenaqian
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was because sound mute is checked and updated on every volume change as well as just toggling the mutes on and off. So I added a small check to only send the mute event if sound is being muted and the soundslider isn't enabled.