blur and focus fix for pausing game #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/container/plugins/PausePlugin.js
Outdated
| this._paused = paused; | ||
|
|
||
| if (this.client) | ||
| if ((this.client) && (!!this._disablePaused)) |
Contributor
There was a problem hiding this comment.
this if statement needs to be wrapping all the contents of the set function for the disable of pause to work properly... as if it is not it will still change the pause button state and still show the pause overlay
|
|
||
| if (this.client) | ||
| if (this._disablePause) | ||
| { |
Contributor
There was a problem hiding this comment.
this line of code needs an exclamation mark in the front of it as the disable functionality is working backwards
Contributor
|
👍 Looks good to me |
| this._isManualPause = false; | ||
|
|
||
| /** | ||
| * If the current application is paused |
Contributor
Author
|
@andrewstart good catch! thanks! |
|
This looks pretty good. I would suggest documenting the addition of |
Contributor
Author
|
Added documentation in the FeaturesPlugin for the |
Contributor
Author
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the disablePause parameter is set in the game, the container should not emit the pause event.