Fullscreen plugin #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
902seanryan
requested changes
Jan 8, 2021
902seanryan
requested changes
Jan 11, 2021
src/plugins/FullScreenPlugin.js
Outdated
|
|
||
|
|
||
| document.addEventListener('fullscreenchange', () => { | ||
| this.sendProperty('fullScreen', this.isFullScreen); |
Contributor
There was a problem hiding this comment.
Is there a reason this one is different from the rest? this.isFullScreen returns an html element object, so the client just receives and object. You could just throw in the this.sendAllProperties() call instead.
src/plugins/FullScreenPlugin.js
Outdated
| toggleFullScreen() { | ||
| if (!document.fullscreenElement) { | ||
| this.iFrame.requestFullscreen().then(() => { | ||
| this.sendProperty(FullScreenPlugin.fullscreenKey, document.fullscreenElement != null ? 'true' : 'false'); |
Contributor
There was a problem hiding this comment.
You can also use the this.sendAllProperties() here, just to avoid the duplication.
…tainer into SpringRoll-develop
Merging changes from dev
902seanryan
reviewed
Jan 12, 2021
src/plugins/FullScreenPlugin.js
Outdated
|
|
||
|
|
||
| document.addEventListener('fullscreenchange', () => { | ||
| this.sendAllProperties(FullScreenPlugin.fullscreenKey, this.isFullScreen); |
Contributor
There was a problem hiding this comment.
sendAllProperties doesn't actually need any input its implemented down on line 75, it just sends the currently active property.
Contributor
There was a problem hiding this comment.
But the sendAllProperties call doesn't actually use the isFullScreen get so it might be worth updating that just to keep everything consistent.
902seanryan
approved these changes
Jan 12, 2021
aberkie
requested changes
Jan 22, 2021
erinjoost
approved these changes
Jan 22, 2021
aberkie
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.