fix: forward requestForDownload in -initWithUpdateRequest:requestForDownload:#317
Merged
Merged
Conversation
MarshallOfSound
force-pushed
the
sam/fix-request-for-download
branch
from
b1a0bbc to
7a0605a
Compare
…ownload: The two-arg convenience initializer accepted a requestForDownload block and discarded it, forwarding a fresh default block to the designated initializer instead. SQRLUpdater.h:152-157 documents this overload as the way to attach Authorization headers to the zip download, and h:106-107 promises the property's default is the argument passed here; neither was true. Regressed in c80f006. The 4-arg designated initializer and the writable requestForDownload property both work, which is likely why this was never reported.
MarshallOfSound
force-pushed
the
sam/fix-request-for-download
branch
from
87143b4 to
31dbc38
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two-arg convenience initializer accepted a
requestForDownloadblock and discarded it, forwarding a fresh default block to the designated initializer instead.SQRLUpdater.h:152-157documents this overload as the way to attachAuthorizationheaders to the zip download, andh:106-107promises the property's default is "the argument that was originally passed to-initWithUpdateRequest:requestForDownload:" — neither was true.Regressed in c80f006. The 4-arg designated initializer and the writable
requestForDownloadproperty both work, which is likely why this was never reported.Adds a test that fails on
main.