Decode/encode entry names of nupkg files to prevent PathTooLongException #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sorry for the huge delay, this is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some files/dirs to be installed contains non-ASCII chars, nuget will %-encode them in
nupkgfile, which may result in very long path and causesPathTooLongExceptionwhile extracting to disk.For example, one Chinese char is encoded as 3 bytes in UTF-8, and each byte is encoded as 3 chars in %-encoding, so one Chinese char is expanded to 9 chars in %-encoding, which causes
PathTooLongExceptiontoo easily (the limit is only 260 chars).This patch decode/encode %-encoded entry names during creation of installation package to prevent this issuse.