-
-
Notifications
You must be signed in to change notification settings - Fork 77
Export stac_list_view, stac_list_tile, and stac_gesture_detector in stac_core #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdded three new exports to the widgets barrel file, exposing stac_list_view, stac_list_tile, and stac_gesture_detector. No existing exports were altered or removed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/stac_core/lib/widgets/widgets.dart (1)
79-81
: Consider alphabetical ordering for better maintainability.The new exports are added at the end of the file, but they could be placed in alphabetical order with the existing exports to maintain consistency and make future maintenance easier.
export 'form/stac_form.dart'; export 'fractionally_sized_box/stac_fractionally_sized_box.dart'; +export 'gesture_detector/stac_gesture_detector.dart'; export 'grid_view/stac_grid_view.dart'; export 'hero/stac_hero.dart';
export 'limited_box/stac_limited_box.dart'; +export 'list_tile/stac_list_tile.dart'; +export 'list_view/stac_list_view.dart'; export 'network_widget/stac_network_widget.dart';export 'wrap/stac_wrap.dart'; -export 'list_view/stac_list_view.dart'; -export 'list_tile/stac_list_tile.dart'; -export 'gesture_detector/stac_gesture_detector.dart';
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/stac_core/lib/widgets/widgets.dart
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: pub_get_check
- GitHub Check: format
- GitHub Check: analyze
🔇 Additional comments (1)
packages/stac_core/lib/widgets/widgets.dart (1)
79-81
: Exports verified — widget files and classes present.
All three exported files exist and define StacListView, StacListTile, and StacGestureDetector.
Description
Related Issues
Closes #
Type of Change
Summary by CodeRabbit