-
-
Notifications
You must be signed in to change notification settings - Fork 77
refactor: Move StacLinearProgressIndicator to stac_core #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughReplaces the Freezed-based StacLinearProgressIndicator model in packages/stac with a json_serializable model in packages/stac_core. Updates the parser to use the new core model and nullable handling. Adjusts exports in both packages. Modifies StacAlign JSON (de)serialization to allow nullable alignment without a default. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant JSON as JSON
participant Core as stac_core: StacLinearProgressIndicator
participant Parser as stac (parser)
participant Flutter as Flutter LinearProgressIndicator
JSON->>Core: fromJson(...)
Note right of Core: value, colors, minHeight, borderRadius parsed (nullable)
Core->>Parser: Model instance
Parser->>Flutter: Build LinearProgressIndicator<br/>value?, backgroundColor?, color?, minHeight?, semantics?, borderRadius?
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (9)
💤 Files with no reviewable changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (7)
Comment |
Description
Move StacLinearProgressIndicator to stac_core for Dart to JSON support
Type of Change
Summary by CodeRabbit