Skip to content

Conversation

@divyanshub024
Copy link
Member

@divyanshub024 divyanshub024 commented Jan 10, 2026

Description

Update table border JSON structure in documentation

Related Issues

Closes #400

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

Summary by CodeRabbit

  • Documentation

    • Updated Table widget border specification examples with simplified consolidated format for color, width, and style
    • Modified borderRadius example to use per-corner radius object notation (topLeft, topRight, bottomLeft, bottomRight)
  • Chores

    • Removed outdated example code and unused imports

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 10, 2026

📝 Walkthrough

Walkthrough

Updated the Table widget border specification in documentation to use a simplified JSON format with consolidated border properties and per-corner borderRadius definitions. Removed an unused home() function and its import from the example gallery.

Changes

Cohort / File(s) Summary
Documentation Update
docs/widgets/table.mdx
Refactored JSON border specification example: replaced per-side border definitions (top, right, bottom, left) with consolidated color/width/style properties; replaced numeric borderRadius with object-based per-corner radii (topLeft, topRight, bottomLeft, bottomRight)
Code Cleanup
examples/stac_gallery/lib/main.dart
Removed unused home() function declaration and associated stac_core import

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰✨ A border refined, from verbose to neat,
With corners named—topLeft to bottomRight sweet!
The gallery's tidied, unused function gone,
Documentation gleams like fresh morning dawn! 🌟

🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR addresses issue #400 by updating documentation for table border JSON structure, but includes unrelated changes (Podfile.lock update and main.dart cleanup) that fall outside the stated objective. Remove the unrelated commit about Podfile.lock and main.dart cleanup to keep changes focused on fixing the table border documentation issue #400.
Out of Scope Changes check ⚠️ Warning The PR includes out-of-scope changes: Podfile.lock dependency lockfile update and removal of imports from main.dart that are unrelated to fixing table border documentation. Exclude the Podfile.lock and main.dart changes from this PR; address them separately to maintain focus on the table border documentation fix.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the table border JSON structure in documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8d17e9 and b8b44be.

⛔ Files ignored due to path filters (1)
  • examples/stac_gallery/ios/Podfile.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • docs/widgets/table.mdx
  • examples/stac_gallery/lib/main.dart
💤 Files with no reviewable changes (1)
  • examples/stac_gallery/lib/main.dart
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: format
  • GitHub Check: analyze
🔇 Additional comments (2)
docs/widgets/table.mdx (2)

146-146: LGTM: Formatting cleanup.

Minor formatting adjustment that maintains valid JSON structure.


38-48: The border JSON structure is correct and consistent with the implementation.

The updated structure with consolidated color, width, style properties and object-based borderRadius properly matches the StacTableBorder implementation. The borderRadius correctly references StacBorderRadius, which parses the per-corner values (topLeft, topRight, bottomLeft, bottomRight) as shown. The documentation at docs/styles/table_border.mdx is also consistent with this structure, confirming the change correctly addresses issue #400.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@divyanshub024 divyanshub024 merged commit 10bc8d2 into dev Jan 10, 2026
6 checks passed
@divyanshub024 divyanshub024 deleted the dv/table-docs branch January 10, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Border param not working for StacTable

2 participants