feat: enhance input decoration with new border options#449
Merged
divyanshub024 merged 3 commits intodevfrom Feb 19, 2026
Merged
feat: enhance input decoration with new border options#449divyanshub024 merged 3 commits intodevfrom
divyanshub024 merged 3 commits intodevfrom
Conversation
- Added `StacInputBorder` parser to handle various input border styles, including error, focused, and enabled states. - Updated `StacInputDecoration` to include new properties for custom borders. - Enhanced `StacInputDecorationTheme` and `StacInputDecoration` parsers to support the new border options. - Updated related documentation and examples to reflect the new features.
Member
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
Contributor
📝 WalkthroughWalkthroughAdds StacInputBorder parsing and wires border fields through InputDecoration models and parsers; extends StacInputDecoration with six border properties; updates melos build steps and some dependencies; and adds pattern-matching helpers to an example Freezed type. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Bumped versions for dependencies in counter_example, movie_app, and stac_gallery to latest releases. - Updated SHA256 checksums for the following packages: characters, matcher, material_color_utilities, and test_api.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@packages/stac/lib/src/parsers/foundation/borders/stac_input_border_parser.dart`:
- Around line 21-25: The current parser returns OutlineInputBorder with a
fallback of BorderRadius.zero when border.borderRadius is null, which diverges
from Flutter's default of BorderRadius.all(Radius.circular(4.0)); update the
fallback used in the OutlineInputBorder creation (the code that references
border.borderRadius?.parse) to use BorderRadius.all(Radius.circular(4.0)) when
border.borderRadius is absent so the parsed OutlineInputBorder matches Flutter's
default appearance.
- Around line 18-19: The case handling StacInputBorderType.underlineInputBorder
currently returns UnderlineInputBorder(borderSide: side) and ignores
StacInputBorder.borderRadius; update the mapping to pass the configured border
radius into UnderlineInputBorder via its borderRadius parameter (e.g.,
borderRadius: <converted StacInputBorder.borderRadius>), converting the STAC
model radius to the Flutter BorderRadius/BorderRadiusDirectional type as needed
and leaving it null to preserve UnderlineInputBorder's defaults when no radius
is specified. Ensure the change is made in the same switch branch that handles
StacInputBorderType.underlineInputBorder so the borderRadius is honored at
runtime.
packages/stac/lib/src/parsers/foundation/borders/stac_input_border_parser.dart
Outdated
Show resolved
Hide resolved
packages/stac/lib/src/parsers/foundation/borders/stac_input_border_parser.dart
Show resolved
Hide resolved
- Updated the `UnderlineInputBorder` and `OutlineInputBorder` cases in the `StacInputBorderParser` to include customizable border radius settings. - Default border radius values are now applied for better visual consistency in input decorations.
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/stac/lib/src/parsers/foundation/borders/stac_input_border_parser.dart (1)
23-33: Addconstto theBorderRadiusfallback literals.Both fallback values use only constant arguments and can be compile-time constants, avoiding a heap allocation on every
parse()call.♻️ Proposed fix
- borderRadius: - border.borderRadius?.parse ?? - BorderRadius.only( - topLeft: Radius.circular(4.0), - topRight: Radius.circular(4.0), - ), + borderRadius: + border.borderRadius?.parse ?? + const BorderRadius.only( + topLeft: Radius.circular(4.0), + topRight: Radius.circular(4.0), + ),- borderRadius: - border.borderRadius?.parse ?? - BorderRadius.all(Radius.circular(4.0)), + borderRadius: + border.borderRadius?.parse ?? + const BorderRadius.all(Radius.circular(4.0)),🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/stac/lib/src/parsers/foundation/borders/stac_input_border_parser.dart` around lines 23 - 33, Add compile-time constants for the fallback BorderRadius literals to avoid allocations: make the fallback BorderRadius instances const (e.g., change BorderRadius.all(Radius.circular(4.0)) to const BorderRadius.all(const Radius.circular(4.0)) and similarly make the BorderRadius.only(...) fallback const with const Radius.circular(4.0)). Update the occurrences around the parse fallback (border.borderRadius?.parse) and the StacInputBorderType.outlineInputBorder/other branch that return BorderRadius.only/BorderRadius.all so the literals are prefixed with const.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@packages/stac/lib/src/parsers/foundation/borders/stac_input_border_parser.dart`:
- Around line 23-33: Add compile-time constants for the fallback BorderRadius
literals to avoid allocations: make the fallback BorderRadius instances const
(e.g., change BorderRadius.all(Radius.circular(4.0)) to const
BorderRadius.all(const Radius.circular(4.0)) and similarly make the
BorderRadius.only(...) fallback const with const Radius.circular(4.0)). Update
the occurrences around the parse fallback (border.borderRadius?.parse) and the
StacInputBorderType.outlineInputBorder/other branch that return
BorderRadius.only/BorderRadius.all so the literals are prefixed with const.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances
StacInputDecorationby introducing support for customizable input borders across different states.A new
StacInputBordermodel and parser have been added, enabling configuration of:errorBorderfocusedBorderfocusedErrorBorderdisabledBorderenabledBorderborderThese updates bring Stac’s input decoration capabilities closer to Flutter’s native
InputDecoration, allowing more granular styling directly from JSON.The changes include:
StacInputBordersupport instac_coreStacInputBorderParserinstacStacInputDecorationandStacInputDecorationThemeparsers to handle new border properties.g.dartfiles## Type of Change
Summary by CodeRabbit
New Features
Refactor
Chores