Refactor/base UI migration#23
Merged
Merged
Conversation
- Replace @radix-ui/react-select, dropdown-menu, scroll-area, slot with @base-ui/react equivalents - Rewrite button.tsx: replace asChild/Slot pattern with render prop - Rewrite confirm-action-popover.tsx using Base UI Popover (adds focus trap, Esc key, ARIA) - Fix Select alignItemWithTrigger=false to prevent popup overlapping trigger - Fix --radix-dropdown-menu-content-available-height → --available-height in ChatHeader - Fix data-[state=open/checked] → data-[open]/data-[selected] in ChatComposerBar - Add data-scroll-viewport attribute to ScrollArea.Viewport; update ChatTranscript queries - Add components.json for shadcn/ui configuration - Add docs/ui-code-review.md with a11y and implementation review Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…etup - fix(dropdown-menu): add onSelect→onClick bridge for Base UI Menu.Item (Radix's onSelect was silently ignored, breaking model/history actions) - fix(select): set alignItemWithTrigger=false and z-[9999] on Positioner to fix WebKit backdrop-filter compositing layer issue - fix(scroll-area): add data-scroll-viewport attribute; update ChatTranscript scroll queries from [data-radix-scroll-area-viewport] - fix(chat-composer): update data-[state=open/checked] → data-[open/selected] for Base UI data attributes - refactor(confirm-action-popover): rewrite with Base UI Popover for proper focus trap and ARIA support - feat(chat-header): add search/filter to model selector dropdown - chore: add Biome linter/formatter config and update tsconfig lib to ES2022 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.