Port ZenHub REST API calls to Java#10
Conversation
| estimate { | ||
| value | ||
| } |
There was a problem hiding this comment.
We're gonna need this when we use getPipelines and getIssuesByPipeline to replace getBoard
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Apollo3 has a less "manual" way to handle pagination. If we wanted to use it, from what I understand, we wouldn't be able to make the client return com.ziro.engineering.zenhub.graphql.sdk objects; we would need to map those objects to our own models. Don't think the juice is worth the squeeze for now.
There was a problem hiding this comment.
I think we will need a chore to move the mappers to github-zenhub-sdk. It would remove a lot of the repetitive methods we're currently writing in our existing mappers. And of course it seems like it would unlock easy pagination for us.
There was a problem hiding this comment.
| /** Required by the generated SDK to handle JSON? i.e. nullable JSON */ | ||
| companion object { | ||
| fun nullable(): NullableAdapter<String> { | ||
| return NullableAdapter(wrappedAdapter = JsonAdapter()) | ||
| } | ||
| } |
There was a problem hiding this comment.
SDK was generating something along the lines of:
jsonAdapter().nullable().fromJson(...), where nullable() returns an Adapter.
There was a problem hiding this comment.
It was just simpler to make the client map the query results to this new data class
There was a problem hiding this comment.
It was just simpler to make the client map the query results to this new data class
justin-sadakhom
left a comment
justin-sadakhom
left a comment
There was a problem hiding this comment.
Overall looks good, just some minor feedback in a few places. You'll need to make some small changes because of feedback I left in the ziro-cli PR.
|
|
||
| group = "com.ziro.engineering" | ||
| version = "2.0.1" | ||
| version = "2.0.2" |
There was a problem hiding this comment.
this shouldn't be 3.0.0? there's definitely some breaking changes to the queries
There was a problem hiding this comment.
I think we will need a chore to move the mappers to github-zenhub-sdk. It would remove a lot of the repetitive methods we're currently writing in our existing mappers. And of course it seems like it would unlock easy pagination for us.
2 participants
Uh oh!
There was an error while loading. Please reload this page.