Switch from v1 to v2 lubrify functions#16
Merged
justin-sadakhom merged 4 commits intodevelopfrom Mar 31, 2025
Merged
Conversation
justin-sadakhom
commented
Mar 14, 2025
| ?.get(0) | ||
| ?.releases | ||
|
|
||
| if (includeIssues) { |
Member
Author
There was a problem hiding this comment.
this skips the issues queries, if needed for performance reasons
justin-sadakhom
commented
Mar 14, 2025
Comment on lines
+489
to
+499
| val issues = mutableSetOf<GetIssuesQuery.Issue>() | ||
| val numPages = ids.size / DEFAULT_PAGE_SIZE | ||
| val idsList = ids.toList() | ||
|
|
||
| for (i in 0..numPages) { | ||
| val query = | ||
| GetIssuesQuery(idsList.subList(i * DEFAULT_PAGE_SIZE, (i + 1) * DEFAULT_PAGE_SIZE)) | ||
| val issuesInPage = | ||
| apolloClient.query(query).toFlow().single().data?.issues?.toSet() ?: emptySet() | ||
| issues.addAll(issuesInPage) | ||
| } |
Member
Author
There was a problem hiding this comment.
the ids need to be batched because the query can only handle 100 ids at a time
justin-sadakhom
commented
Mar 21, 2025
| val childIssuesIds = mutableSetOf<String>() | ||
| var endCursor: String? = null | ||
| var hasNextPage: Boolean | ||
| fun getEpicsByIds(epicIds: List<String>): List<EpicData> = runBlocking { |
Member
Author
There was a problem hiding this comment.
this change supports grabbing multiple epics in a single query, whereas before we'd have to do x queries for x epics
justin-sadakhom
commented
Mar 21, 2025
Comment on lines
+499
to
+517
| val issues = mutableSetOf<GetIssuesQuery.Issue>() | ||
| val numPages = ids.size / DEFAULT_PAGE_SIZE | ||
| val idsList = ids.toList() | ||
|
|
||
| for (i in 0..numPages) { | ||
| val query = | ||
| GetIssuesQuery( | ||
| idsList | ||
| .stream() | ||
| .skip(i * DEFAULT_PAGE_SIZE.toLong()) | ||
| .limit(DEFAULT_PAGE_SIZE.toLong()) | ||
| .toList()) | ||
|
|
||
| val issuesInPage = | ||
| apolloClient.query(query).toFlow().single().data?.issues?.toSet() ?: emptySet() | ||
| issues.addAll(issuesInPage) | ||
| } | ||
|
|
||
| issues |
Member
Author
There was a problem hiding this comment.
handles splitting ids into groups of 100 for the client, so client doesn't have to worry about pagination details and can just pass in the parameters hassle-free
justin-sadakhom
commented
Mar 21, 2025
Comment on lines
+597
to
+616
|
|
||
| private fun handleQueryErrors( | ||
| error: com.apollographql.apollo3.api.Error, | ||
| epicIds: List<String> | ||
| ) { | ||
| when (error.message) { | ||
| "Invalid global id: Make sure id is in Base64 format" -> { | ||
| throw IllegalArgumentException(error.message) | ||
| } | ||
|
|
||
| "Resource not found" -> { | ||
| val missingEpicIndex = | ||
| (error.path?.get(1) as? Int) | ||
| ?: throw IllegalArgumentException("Value cannot be converted to Int") | ||
|
|
||
| throw IllegalArgumentException( | ||
| "Failed to retrieve epic with ID: ${epicIds[missingEpicIndex]}") | ||
| } | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
handles errors for the query that retrieves epics. I included this to provide more useful feedback to client if one of their ids causes a problem (wrong id format or id isn't tied to an epic). that way they can more easily troubleshoot problematic ids
justin-sadakhom
deleted the
19177_switch-from-v-1-to-v-2-lubrify-functions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is necessary because we missed implementing pagination for releases in a previous story. It also includes some performance enhancements.