Ship-it job fails when the release contains over 900 issues#20
Merged
justin-sadakhom merged 8 commits intodevelopfrom Jun 25, 2025
Conversation
…contains-over-900-issues
justin-sadakhom
commented
Jun 19, 2025
|
|
||
| if (queryResult?.workspace?.sprints?.nodes != null) { | ||
| sprints.addAll(queryResult.workspace!!.sprints.nodes) | ||
| sprints.addAll(queryResult.workspace.sprints.nodes) |
Member
Author
There was a problem hiding this comment.
IDE was complaining that this is unnecessary
justin-sadakhom
commented
Jun 19, 2025
| private const val DEFAULT_PAGE_SIZE = 100 | ||
|
|
||
| class ZenHubClient(private val zenhubWorkspaceId: String = DEFAULT_WORKSPACE_ID) : AutoCloseable { | ||
| class ZenHubClient(val zenhubWorkspaceId: String = DEFAULT_WORKSPACE_ID) : AutoCloseable { |
Member
Author
There was a problem hiding this comment.
this allows Spring to inject zenhubWorkspaceId through application properties. makes it simple to set a different id for prod code (engineering board) and test code (collision course)
caustin-ziro
approved these changes
Jun 24, 2025
| @@ -1,4 +1,4 @@ | |||
| var currentVersion = "5.0.0" | |||
| var currentVersion = "5.2.0" | |||
Contributor
There was a problem hiding this comment.
not sure what's going on with the blame here, but I see 5.2.0 already on develop:
justin-sadakhom
deleted the
20144-ship-it-job-fails-when-the-release-contains-over-900-issues
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.