Authentication: fix insecure auth redirect#113
Merged
NickCraver merged 1 commit intomasterfrom Dec 13, 2020
Merged
Conversation
This resolves https://meta.stackexchange.com/questions/357811/chrome-warns-me-my-connection-is-not-secure-when-authenticating-in-sede-with-a-g, which was not using https:// when deployed behind a TLS terminator and the backend to web was over `:80`.
Contributor
|
I don't think IsSecureConnection will return true unless you forward TLS from the terminator to the IIS server, unless you do some Header trickery by providing things like X-Forwarded-Proto and handling that in the call. |
Contributor
Author
|
@rschrieken It should work - that |
yellis
approved these changes
Dec 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves https://meta.stackexchange.com/questions/357811/chrome-warns-me-my-connection-is-not-secure-when-authenticating-in-sede-with-a-g, which was not using https:// when deployed behind a TLS terminator and the backend to web was over
:80.