Fix RedisResult.ToDictionary. #1471
Merged
mgravell merged 1 commit intoStackExchange:masterfrom May 22, 2020
Merged
Conversation
…t half of the array. Also added test coverage for this method.
Collaborator
|
Not at a PC to check, but... From inspection only (not run), the old code should work fine. What error were you seeing? |
Contributor
Author
|
Only one half of the results array was parsed into a dictionary, because the for loop was set to stop when |
Collaborator
|
Ah yes, up on 225; yes, that's not good - thanks for resolving. |
Collaborator
|
Merging, much appreciated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it would only parse the first half of the array. Also added test coverage for this method.