Fix RESP3 client handshakes on non-RESP3 servers#3037
Merged
Conversation
- `HELLO 3` with `3` response: pass - `HELLO 3` with `-ERR` response: fail - `HELLO 3` with `2` response: fail
philon-msft
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RESP2 on RESP2 servers, and RESP3 on RESP3 servers have both always been fine; however, requesting RESP3 on servers that either don't support RESP3 at all (
-ERR) or (like DMC in the past) reject RESP3: have had bumps. We fix this here by:fix #2783
Tests use the in-process test infrastructure, simulating:
HELLO(down-level RESP2 Redis)HELLObut still only supports RESP2 (down-level DMC)