-
Notifications
You must be signed in to change notification settings - Fork 59
feat: Add support for Stack Snippets #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Stack Snippets #400
Conversation
|
After discussion, we're going to amend the external plugin architecture to make this work as an external plugin. This also means moving the |
150ce40 to
608b867
Compare
giamir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @threefjefff for implementing this integration. I think we are very close to be able to merge. The main ask I have is to make explicit the parts of the "core" editor which we rely on in the plugin. This should help us greatly if we will eventually extract the plugin and in general with evolving the core parts with confidence. Being able to see at a glance what is exposed. The comments scattered through the PR are all related to this point.
Apart from that I also have a couple of suggestions regarding the demo site:
- I would recommend to create a brand new page dedicated to showcasing the stacks snippets plugin. It is big enough that deserves it. It will also make it easier to test/try by having some prebaked examples.
- Given we will have a new page for the snippets plugin I would recommend to turn off the plugin from any other page. This emphasize that snippets are not part of the "core" editor and need to be injected as a plugin
- Cosmetic: I would suggest to change the max width of the main element from
wmx6towmx7(seelayout.html). This is because we have several menu items now and the horizontal scollbar creeps in, in some pages.
Let me know if my suggestions make sense. Happy to sync if necessary to discuss this further. Thanks for bringing snippets to the finish line. It is a big feat. ❤️
giamir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @threefjefff for addressing my comments. Let's merge it! 🙂
Add Stacks Snippet support to the editor as an external plugin.
PR Checklist
/** ... */docsbug/enhancementand other labels as appropriateEnvironment(s) tested
Additional context
This is the baseline for Stack Snippets: