test(visual): add improved baseline images update workflow#1611
Merged
dancormier merged 1 commit intodevelopfrom Jan 25, 2024
Merged
Conversation
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dancormier
approved these changes
Jan 25, 2024
Contributor
dancormier
left a comment
dancormier
left a comment
There was a problem hiding this comment.
I tested this out and it works as expected. This is a nice enhancement. Thank you for this update @giamir!
dancormier
deleted the
gbuoncristiani/visual-regression-tests-enhancement
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR change the way we upgrade our baseline images so that only the failing snapshots get regenerated.
It should also provide a better way to look at diff directly in vscode.
Run this command
git config diff.lfs.textconv catand install this vscode extension for optimal experience.Chekout the updated readme for more info.