Skip to content

fix(pagination):improve focus style to meet WCAG 2.2 AA #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dancormier merged 2 commits into from
Jan 26, 2024
Merged

fix(pagination):improve focus style to meet WCAG 2.2 AA #1612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ed2d29
fix(pagination):improve focus style to meet WCAG 2.2 AA
dancormier Jan 25, 2024
5c9661f
docs(pagination): improve example accessibility
dancormier Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 56 additions & 14 deletions docs/product/components/pagination.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,26 +32,68 @@
<div class="stacks-preview">
{% highlight html %}
<div class="s-pagination">
<span class="s-pagination--item is-selected" aria-current="page">1</span>
<a class="s-pagination--item" href="…">2</a>
<a class="s-pagination--item" href="…">3</a>
<a class="s-pagination--item" href="…">4</a>
<a class="s-pagination--item" href="…">5</a>
<a class="s-pagination--item is-selected" href="…" aria-current="page">
<span class="v-visible-sr">page</span>
1
</a>
<a class="s-pagination--item" href="…">
<span class="v-visible-sr">page</span>
2
</a>
<a class="s-pagination--item" href="…">
<span class="v-visible-sr">page</span>
3
</a>
<a class="s-pagination--item" href="…">
<span class="v-visible-sr">page</span>
4
</a>
<a class="s-pagination--item" href="…">
<span class="v-visible-sr">page</span>
5
</a>
<span class="s-pagination--item s-pagination--item__clear">…</span>
<a class="s-pagination--item" href="…">1096917</a>
<a class="s-pagination--item" href="…">Next</a>
<a class="s-pagination--item" href="…">
<span class="v-visible-sr">page</span>
122386
</a>
<a class="s-pagination--item" href="…">
Next
<span class="v-visible-sr">page</span>
</a>
</div>
{% endhighlight %}
<div class="stacks-preview--example overflow-x-auto">
<div class="s-pagination">
<span class="s-pagination--item is-selected" aria-current="page">1</span>
<a class="s-pagination--item" href="#">2</a>
<a class="s-pagination--item" href="#">3</a>
<a class="s-pagination--item" href="#">4</a>
<a class="s-pagination--item" href="#">5</a>
<a class="s-pagination--item is-selected" href="#" aria-current="page">
<span class="v-visible-sr">page</span>
1
</a>
<a class="s-pagination--item" href="#">
<span class="v-visible-sr">page</span>
2
</a>
<a class="s-pagination--item" href="#">
<span class="v-visible-sr">page</span>
3
</a>
<a class="s-pagination--item" href="#">
<span class="v-visible-sr">page</span>
4
</a>
<a class="s-pagination--item" href="#">
<span class="v-visible-sr">page</span>
5
</a>
<span class="s-pagination--item s-pagination--item__clear">…</span>
<a class="s-pagination--item" href="#">1096917</a>
<a class="s-pagination--item" href="#">Next</a>
<a class="s-pagination--item" href="#">
<span class="v-visible-sr">page</span>
122386
</a>
<a class="s-pagination--item" href="#">
Next
<span class="v-visible-sr">page</span>
</a>
</div>
</div>
</div>
Expand Down
11 changes: 11 additions & 0 deletions lib/components/pagination/pagination.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
--_pa-item-bg: transparent;
--_pa-item-bc: var(--bc-darker);
--_pa-item-fc: var(--fc-medium);
--_pa-item-bg-focus: var(--black-400);
--_pa-item-fc-focus: var(--white);
--_pa-item-bg-hover: var(--black-225);
--_pa-item-bc-hover: var(--bc-darker);
--_pa-item-fc-hover: var(--fc-dark);
Expand All @@ -15,6 +17,7 @@
--_pa-item-bg: var(--theme-primary);
--_pa-item-bc: transparent;
--_pa-item-fc: var(--white);
--_pa-item-bg-focus: var(--theme-primary-400);
}
&.s-pagination--item__clear {
--_pa-item-bg: transparent;
Expand All @@ -36,6 +39,14 @@
color: var(--_pa-item-fc-hover);
}

&:focus-visible {
background-color: var(--_pa-item-bg-focus);
border-color: var(--theme-secondary-400) !important;
box-shadow: inset 0 0 0 var(--su-static2) var(--theme-secondary-400), inset 0 0 0 var(--su-static4) var(--black-050);
color: var(--_pa-item-fc-focus);
outline: var(--su-static2) solid transparent;
}

background-color: var(--_pa-item-bg);
border: 1px solid var(--_pa-item-bc);
color: var(--_pa-item-fc);
Expand Down