fix(focus): change focus ring from black-050 to white#1623
Merged
dancormier merged 1 commit intodevelopfrom Jan 30, 2024
Merged
fix(focus): change focus ring from black-050 to white#1623dancormier merged 1 commit intodevelopfrom
black-050 to white#1623dancormier merged 1 commit intodevelopfrom
Conversation
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CGuindon
approved these changes
Jan 30, 2024
dancormier
added a commit
that referenced
this pull request
Jan 30, 2024
dancormier
added a commit
that referenced
this pull request
Jan 30, 2024
dancormier
added a commit
that referenced
this pull request
Jan 30, 2024
* fix(toggle-switch): improve focus style to meet WCAG 2.2 AA [STACK-543](https://stackoverflow.atlassian.net/browse/STACKS-543) * fix(toggle): change focus ring from `black-050` to `white` Related #1623
dancormier
added a commit
that referenced
this pull request
Jan 31, 2024
* fix(block-link): improve focus style to meet WCAG 2.2 AA Resolves [STACKS-545](https://stackoverflow.atlassian.net/browse/STACKS-545) * fix(block-link): change focus ring from `black-050` to `white` Related #1623 * Add border radius sm to block-link focus style Addresses #1621 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #1620 (review)
@CGuindon This PR updates the focus ring color from
black-050towhitefor button, pagination, and tag components so the focus ring matches the background of the page in all color modes. If this looks right, I'll update the values for the in-flight PR as well.