test(topbar): add visual regression tests#1624
Merged
dancormier merged 9 commits intodevelopfrom Feb 1, 2024
Merged
Conversation
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACKS-551
This PR adds tests for the topbar component. My hope is that we can get these tests merged, then pull these changes into the PPCP refactor to give us confidence that the refactor doesn't introduce regressions 🤞 After that, I'd like to start the focus style updates on the newly refactored topbar Less.
@giamir when you have a moment, can you look into why the searchbar is rendering too high in test images? I've exhausted anything I can come up with (I even tried just rendering the markup from our docs site and the searchbar is still misaligned). No rush on this.