fix(test): ensure includeNullModifier value is honored#1638
Merged
dancormier merged 2 commits intodevelopfrom Feb 8, 2024
Merged
fix(test): ensure includeNullModifier value is honored#1638dancormier merged 2 commits intodevelopfrom
includeNullModifier value is honored#1638dancormier merged 2 commits intodevelopfrom
Conversation
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
giamir
approved these changes
Feb 8, 2024
Contributor
giamir
left a comment
giamir
left a comment
There was a problem hiding this comment.
LGTM. Thanks 🙏
Sidenote
I might be going a bit meta here but this specific test utils is getting so complex that might deserve its own set of unit tests. 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After having visual failures of test(select): add a11y, visual tests #1498 after it had been updated with the latest test changes in develop, I realized something was not working as expected.
Turns out that we're not fully honoring the
includeNullModifieroption for secondary and global modifiers (this bug predates the recent test changes). This PR fixes that bug.